Skip to content

Commit

Permalink
first draft of codeowners file for analysts guide (#135)
Browse files Browse the repository at this point in the history
* first draft of codeowners file for analysts guide

* rename methodology template for EES

* remove attempts to publish from PR as not needed
  • Loading branch information
cjrace authored Jan 10, 2025
1 parent af405c2 commit 662b0a5
Show file tree
Hide file tree
Showing 6 changed files with 41 additions and 3 deletions.
37 changes: 37 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# these will always be requested as reviewer when someone
# opens a pull request.
* @jen-machin

# The workflow and website setup files are jointly owned
_quarto.yml @jen-machin @cjrace
.github @jen-machin @cjrace

# The following files and folders are owned by the SDT team
/ADA/ @jen-machin @chfoster @Lsnaathorst1 @mzayeddfe
/RAP/ @jen-machin @chfoster @Lsnaathorst1 @mzayeddfe
/resources/ @jen-machin @chfoster @Lsnaathorst1 @mzayeddfe
/learning-development/ @jen-machin @chfoster @Lsnaathorst1 @mzayeddfe

# The following files and folders are owned by the EESP team
/statistics-production/api-data-standards.qmd @cjrace @rmbielby
/statistics-production/ees.qmd @cjrace @rmbielby
/statistics-production/embedded-charts.qmd @cjrace @rmbielby
/statistics-production/examples.qmd @cjrace @rmbielby
/statistics-production/ud.qmd @cjrace @rmbielby
/data_examples/ @cjrace @rmbielby
/writing-visualising/dashboards_rshiny.qmd @cjrace @rmbielby
/writing-visualising/dashboards.qmd @cjrace @rmbielby
/resources/Methodology_template_EES.docx @cjrace @rmbielby

# The following files relate to publication scrums
/resources/Content_Design_Logbook_Dashboards.xlsx @rmbielby
/resources/Content_Design_Logbook.xlsx @rmbielby
/resources/Content_Design_Scrum_Progression.pptx @rmbielby
/resources/Content_Design_Scrums_Insights_final.docx @rmbielby
/statistics-production/scrums.qmd @rmbielby

# The following files cover our take on the analysis function best practice
/writing-visualising/visualising.qmd @cjrace @jen-machin
/writing-visualising/writing.qmd @cjrace @jen-machin
2 changes: 0 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ on:
workflow_dispatch:
push:
branches: main
pull_request:
branches: main

name: Publish to pages

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ ADA diagram - https://app.diagrams.net/?libs=general;flowchart#G1oL9XauLLcVVbF5O

## Contribution

Pages from this guide have different code owners, their review will automatically be sought on any contributions you make. For full details of the codeowners in this repo, see the [.github/CODEOWNERS file](https://github.com/dfe-analytical-services/analysts-guide/blob/main/.github/CODEOWNERS).

If you're interested in contributing to this project, have a read of the [contributing guidelines](https://github.com/dfe-analytical-services/analysts-guide/blob/main/CONTRIBUTING.md).

---
Expand Down
1 change: 1 addition & 0 deletions analysts-guide.Rproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: d026eaf1-b8f5-4646-83f7-676fa8b8a4fd

RestoreWorkspace: Default
SaveWorkspace: Default
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion statistics-production/ees.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -1322,7 +1322,7 @@ See our guidance on Good examples in EES for a [best practice example of a publi
## Methodology


Appropriate methodological information must be made available for all published Official Statistics releases. Methodologies can follow our recommended [methodology template](../resources/Methodology template EES.docx), to ensure all the essential details are covered.
Appropriate methodological information must be made available for all published Official Statistics releases. Methodologies can follow our recommended [methodology template](../resources/Methodology_template_EES.docx), to ensure all the essential details are covered.

If you have not created or published a methodology page on EES before, the first thing your publication owner will need to do is create a methodology page.

Expand Down

0 comments on commit 662b0a5

Please sign in to comment.