Add Slime Block #413
Closed
Add Slime Block #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmm545
reviewed
Jan 25, 2022
T14Raptor
requested changes
Jan 25, 2022
| package block | ||
|
|
||
| // A Slime block is a translucent block that entities can bounce on | ||
| type Slime struct { |
There was a problem hiding this comment.
This should be called SlimeBlock and the file should be renamed to slime_block.go
| package block | ||
|
|
||
| // Slime is a translucent block that entities can bounce on. | ||
| type Slime struct { |
There was a problem hiding this comment.
This also should implement block.LightDiffuser with LightDiffusionLevel() returning the correct light diffusion level
| package block | ||
|
|
||
| // Slime is a translucent block that entities can bounce on. | ||
| type Slime struct { |
There was a problem hiding this comment.
This also also should implement block.EntityLander, and should reset the entity's fall distance if it implements FallDistanceEntity
|
Closing in favor of #445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the slime blocks so I implemented them, it's client side everything that is slowing down and jumping
Here is a video to show that it works client side: click here
(it's on df of course)