-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some pages to development section #71
Conversation
The location of menu items on the sidebar is based on the I also fixed an issue where "On this page:" was showing up even if the |
This may be a bigger issue. We are using the section-nav.html file to build this component, and it's not doing any checks for content in the pages that it's using to build the menu. I've only just started using Hugo myself, but now I'm curious if there is a way of checking for empty files -- if we can check, then we can render that menu content a little differently. My usual workaround has been to add content to those top-level menu pages 😅️ |
It doesn't matter that much. We can write some random text about "This section explains how you can....blahblah". |
This is definitely the easier solution 😉️ |
I'll keep thinking on this menu issue though, this is going to come up more and more as the Hugo Netlify |
@@ -4,7 +4,7 @@ description: "" | |||
date: 2020-09-30 | |||
draft: false | |||
toc: true | |||
weight: 100 | |||
weight: 3100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the default sort is alphabetical when files have the same weight.
dev-integration-tests.md
and dev-releases.md
both have a weight of 3100 set. I'd suggest being more explicit about the weights, so even if you want alphabetical sorting, I'd set the weights to reflect that.
(lower weight gets higher precedence)
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Updatating to group pages more clearly. Moving Developement section to end of list Signed-off-by: Nate W <[email protected]>
Correcting layout so that "On this Page:" only appears when "toc" frontmatter variable is set to true Signed-off-by: Nate W <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
8330ba7
to
1e9a1d1
Compare
I think this is ready to be merged. Further improvements can be done in additional PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, otherwise LGTM
@@ -0,0 +1,12 @@ | |||
--- | |||
title: "Development" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we may want to put a list of the development pages on this page. We could probably write a partial to build the list for us automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
Co-authored-by: Nate W. <[email protected]>
Thanks for the review @nate-double-u |
This PR moves some development pages to a new section called development.
Some remaining tasks:
@nate-double-u can you help me out here? I'm not a huge Hugo expert as you are. ;)