storage/kubernetes: fix conflict error detection in TRP creation #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
force-pushed
the
tpr-already-exists
branch
from
0b6b794 to
3a06bc6
Compare
storage/kubernetes/storage.go
Outdated
| cli.logger.Errorf("third party resource already created %q", r.ObjectMeta.Name) | ||
| continue | ||
| } | ||
| if err == storage.ErrAlreadyExists { |
There was a problem hiding this comment.
Do we want to have a similar check for storage.ErrNotFound and have a separate message for that too?
There was a problem hiding this comment.
storage.ErrNotFound would mean that TPRs weren't enabled on the server. hmmm, maybe? Let me go add that.
PR dexidp#815 fixed the Kubernetes storage implementation by correctly returning storage.ErrAlreadyExists on POST conflicts. This caused a regression in TPR creation (dexidp#822) when some, but not all, of the resources already existed. E.g. for users upgrading from old versions of dex. Fixes dexidp#822
ericchiang
force-pushed
the
tpr-already-exists
branch
from
3a06bc6 to
a7b8e52
Compare
|
@rithujohn191 updated the logging message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #815 fixed the Kubernetes storage implementation by correctly
returning storage.ErrAlreadyExists on POST conflicts. This caused a
regression in TPR creation (#822) when some, but not all, of the
resources already existed. E.g. for users upgrading from old
versions of dex.
Fixes #822