Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace godep with glide #399

Merged
merged 2 commits into from
Apr 13, 2016
Merged

replace godep with glide #399

merged 2 commits into from
Apr 13, 2016

Conversation

ericchiang
Copy link
Contributor

Please review the first commit which updates the documentation and adds the glide files.

The second commit is huge as glide does not remove _test.go files and testdata.

See coreos/docs#775 for discussion.

Closes #387

@chancez
Copy link
Contributor

chancez commented Apr 10, 2016

@ericchiang We can use https://github.com/sgotti/glide-vc to remove some things (we can't use only-go because it will strip files needed by cgo), but it would help with test files, and packages which are not part of the direct import-tree.

@ericchiang
Copy link
Contributor Author

Just to follow up from outside discussions. We like glide-vc but don't like adding an additional dependency in order to work with the vendor directory. If this is functionality is important then glide should implement it or we should consider a different tool.

There's some discussion here Masterminds/glide#166

@ericchiang
Copy link
Contributor Author

I'd also like to note that I'm fine with glide not removing unused sub-packages.

@bobbyrullo
Copy link
Contributor

how does one do the equivalent of godep go {build|test} ?

@ericchiang
Copy link
Contributor Author

Ensure you have either Go 1.6 or Go 1.5 with GO15VENDOREXPERIMENT=1. Then just use the go tool. Since glide puts everything in ./vendor all dex code will build using that directory.

@bobbyrullo
Copy link
Contributor

LGTM

@ericchiang ericchiang merged commit 58d9ae9 into dexidp:master Apr 13, 2016
@sym3tri
Copy link

sym3tri commented Apr 14, 2016

🎉

@ericchiang ericchiang deleted the glide branch April 20, 2016 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants