OIDC Connector: Support for IssuerAlias and group claims with maps instead of strings #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meldsza
force-pushed
the
oidc-issuer-alias
branch
from
0314520 to
9fade21
Compare
meldsza
force-pushed
the
oidc-issuer-alias
branch
from
9fade21 to
c9a434f
Compare
|
Hi @nabokihms, |
nabokihms
approved these changes
Oct 18, 2024
|
@meldsza Hi, the PR looks good. Could you:
|
meldsza
force-pushed
the
oidc-issuer-alias
branch
from
01acd98 to
c9a434f
Compare
Signed-off-by: Melroy Dsouza <[email protected]>
meldsza
force-pushed
the
oidc-issuer-alias
branch
from
c9a434f to
4328414
Compare
|
@nabokihms I have rebased the branch and created another PR for the website/docs: Please approve the workflows so that they can run and provide test coverage |
dariusbakunas
approved these changes
Oct 29, 2024
nabokihms
approved these changes
Oct 31, 2024
|
Thanks for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support for IssuerAlias and group claims with maps instead of strings in the OIDC Connector
What this PR does / why we need it
Some Identity Providers like IDCS and Azure have different issuer urls in the OIDC discovery endpoint. This leads to the issuer url check failing. This PR adds support for IssuerAlias which would override the issuer check with the value of issuer to be checked in the discovery endpoint.
Many Identity Providers return the groups as a list of maps with the name field. This functionality already exists in the oauth connector but does not currently exist in the OIDC connector. This PR adds support for this scenario and adds relevant tests cases
Special notes for your reviewer