feat: Add support for configurable prompt type for Google connector #3475
+74
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisek
force-pushed
the
feat/google-connector-configurable-prompt-type
branch
from
f92ae9d
to
188d22c
Compare
nabokihms
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Looks good to me, thanks! The only thing left is satisfying the linter.
Oh, and one more. Could you please also open a PR to the website repo with the doc fix? https://dexidp.io/docs/connectors/google/
Signed-off-by: abhisek <[email protected]>
abhisek
force-pushed
the
feat/google-connector-configurable-prompt-type
branch
from
188d22c
to
aef0bca
Compare
|
@nabokihms Thanks for the comment. I have fixed the linter issue. I have also raised a separate PR to the website repo to update documentation. |
Signed-off-by: Maksim Nabokikh <[email protected]>
nabokihms
approved these changes
Apr 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for configurable prompt type for Google Connector. Reference #3450
What this PR does / why we need it
promptparameter in login URL generated by Google connectorSpecial notes for your reviewer
Ref #3450
The original ask was to avoid the user experience of consent screen every time authentication flow goes through
dexinto Google by skippingprompt=consentflag. As per OIDC specification, there is no valid value forpromptparam to achieve this. So this PR just allows the ability to set the value ofpromptparameter through configuration. Setting an explicit""(empty) value for prompt should be functionally equivalent for skipping it for Google connector