Add support for extra claims to authproxy connector #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkjpryor
force-pushed
the
feature/authproxy-extra-headers
branch
2 times, most recently
from
38d0bce
to
5e97a76
Compare
mkjpryor
force-pushed
the
feature/authproxy-extra-headers
branch
from
5e97a76
to
497483d
Compare
nabokihms
requested changes
Jun 21, 2023
mkjpryor
force-pushed
the
feature/authproxy-extra-headers
branch
from
497483d
to
b07a9fc
Compare
|
I have rebased, addressed the linting issues and added an extra test. Can you re-review please? |
Signed-off-by: Matt Pryor <[email protected]>
Signed-off-by: Matt Pryor <[email protected]>
Signed-off-by: Matt Pryor <[email protected]>
mkjpryor
force-pushed
the
feature/authproxy-extra-headers
branch
from
8681440
to
b80935a
Compare
nabokihms
approved these changes
Dec 28, 2023
|
@mkjpryor sorry for the long delay. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for some additional headers to be propagated into claims in the authproxy connector.
What this PR does / why we need it
I am using Dex with authproxy to turn an existing IdP, whose code is not under my control, into an OIDC provider. I want to be able to propagate the user ID and email address from the underlying IdP as OIDC claims alongside the username, which is not possible with the current headers and claims supported by the authproxy connector.
This PR adds support for two extra headers that can be used to propagate the user ID and email from the underlying IdP, and sets the claims. When these additional headers are not set, it reduces to the previous mode.
Special notes for your reviewer
Does this PR introduce a user-facing change?