remove redefinition of providedCodeVerifier, fixed spelling (#6)

Signed-off-by: Bernd Eckstein <[email protected]> Signed-off-by: Bernd Eckstein <[email protected]>
dexidp · Sep 16, 2020 · a1aab00 · a1aab00
1 parent 369674f
commit a1aab00
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/server/handlers.go b/server/handlers.go
@@ -816,13 +816,11 @@ func (s *Server) handleAuthCode(w http.ResponseWriter, r *http.Request, client s
 	providedCodeVerifier := r.PostFormValue("code_verifier")
 
 	if providedCodeVerifier != "" && codeChallengeFromStorage != "" {
-		providedCodeVerifier := r.PostFormValue("code_verifier")
 		calculatedCodeChallenge, err := s.calculateCodeChallenge(providedCodeVerifier, authCode.CodeChallenge.CodeChallengeMethod)
 		if err != nil {
 			s.tokenErrHelper(w, errServerError, "", http.StatusInternalServerError)
 			return
 		}
-
 		if codeChallengeFromStorage != calculatedCodeChallenge {
 			s.tokenErrHelper(w, errInvalidGrant, "Invalid code_verifier.", http.StatusBadRequest)
 			return

diff --git a/server/server_test.go b/server/server_test.go
@@ -1332,7 +1332,7 @@ func checkErrorResponse(err error, t *testing.T, tc test) {
 				tc.name, details.Error, details.ErrorDescription, tc.tokenError.Error)
 		}
 	} else {
-		t.Errorf("%s: unexpedted error type: %s. expected *oauth2.RetrieveError", tc.name, reflect.TypeOf(err))
+		t.Errorf("%s: unexpected error type: %s. expected *oauth2.RetrieveError", tc.name, reflect.TypeOf(err))
 	}
 }