Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing argument to MoyaSugarProvider super.init method #26

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

OhKanghoon
Copy link
Contributor

@OhKanghoon OhKanghoon commented Apr 1, 2020

session is missing in super.init() in MoyaSugarProvider initializer

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #26 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   83.51%   83.69%   +0.17%     
==========================================
  Files           5        5              
  Lines          91       92       +1     
==========================================
+ Hits           76       77       +1     
  Misses         15       15              
Impacted Files Coverage Δ
Sources/MoyaSugar/MoyaSugarProvider.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c868c...c2afe89. Read the comment docs.

@devxoul devxoul merged commit 90368e2 into devxoul:master Apr 2, 2020
@devxoul
Copy link
Owner

devxoul commented Apr 2, 2020

Thanks!

@OhKanghoon OhKanghoon deleted the bug/moya-sugar-provider-init branch April 2, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants