Use colored2 instead of colorize for CLI colors #66
Conversation
Colorize and colored2 cannot be used at the same time due to them defining conflicting entities in the global space. Since CocoaPods uses colored2 and it's likely that someone would use CocoaSeeds along side CocoaPods it's better to use colored2 in CocoaSeeds too.
| gemspec.scan(/(?<=s\.add_runtime_dependency ).*/).each do |dependency| | ||
| eval "gem #{dependency}" | ||
| end | ||
| gemspec |
There was a problem hiding this comment.
Can you explain me about this change?
There was a problem hiding this comment.
It's the recommended way to include run time and delelopment dependecies for local development of the gem.
From the bundler docs
Gemfile: Used to manage gem dependencies for our library’s development. This file contains a gemspec line meaning that Bundler will include dependencies specified in foodie.gemspec too. It’s best practice to specify all the gems that our library depends on in the gemspec.
I also added rake as a development dependency since it's used to run the tests
There was a problem hiding this comment.
Wow didn't know that. Thanks for your detailed explanation!
|
@k0nserv, thanks for your contribution! Your commits have been shipped along with 0.8.3 release 👍 |
|
Wow! Awesome thanks for the speedy release 👍 |
Colorize and colored2 cannot be used at the same time due to
them defining conflicting entities in the global space. Since
CocoaPods uses colored2 and it's likely that someone would use
CocoaSeeds along side CocoaPods it's better to use colored2 in
CocoaSeeds too.