Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

Update to support CocoaPods 1.0 #59

Merged
merged 3 commits into from
Jul 11, 2016
Merged

Update to support CocoaPods 1.0 #59

merged 3 commits into from
Jul 11, 2016

Conversation

argon
Copy link
Contributor

@argon argon commented May 13, 2016

No description provided.

@devxoul
Copy link
Owner

devxoul commented May 13, 2016

@argon, Thanks! can you please exclude the version.rb file from diff?

@argon
Copy link
Contributor Author

argon commented May 13, 2016

Done

@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

@devxoul can we get this merged? I had forgotten that I'm still using my own fork.

@devxoul
Copy link
Owner

devxoul commented Jul 11, 2016

@argon, I had a question but forgot it. My apology 🙏 How about making xcodeproj dependency version to >= 0.28 to let CocoaPods < 1.0 users available to use CocoaSeeds?

@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

@devxoul done

@devxoul
Copy link
Owner

devxoul commented Jul 11, 2016

This is cool. I'll merge it just after the CI has done 😄

activesupport-5.0.0 imposes this requirement
@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

I have raised the minimum ruby version to keep activesupport happy.

@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

@devxoul There is another problem with the CI:

Seeds::Exception: JLToast: Couldn't find the repository.

Any ideas?

@devxoul
Copy link
Owner

devxoul commented Jul 11, 2016

@argon, Yeah, that's because I removed the JLToast repo from BitBucket :( I created again and retried the CI. Dont' worry!

@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

@devxoul there's another problem now. The tests pass locally on my machine.

@devxoul
Copy link
Owner

devxoul commented Jul 11, 2016

It seems that uppercases are not allowed in BitBucket repo URLs :( I'm gonna make a new PR to force BitBucket URLs lowercase. => It works on git cloning

@devxoul
Copy link
Owner

devxoul commented Jul 11, 2016

I think it was just a cache problem :(

@devxoul devxoul merged commit 295a4e9 into devxoul:master Jul 11, 2016
@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

Thanks!

@argon
Copy link
Contributor Author

argon commented Jul 11, 2016

@devxoul One more thing: Would you be able to create a new release for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants