Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v2.9.3 #40

Merged
merged 8 commits into from
Jan 9, 2024
Merged

Update v2.9.3 #40

merged 8 commits into from
Jan 9, 2024

Conversation

devuri
Copy link
Owner

@devuri devuri commented Jan 9, 2024

No description provided.

Copy link

github-actions bot commented Jan 9, 2024

✨ Features

b8d8a71 - adds notification_email()

Changed files

  • src/InstagramData.php

📋 Changes

8dbdfba - chore:v2.9.3

Changed files

  • index.php
  • readme.txt
  • sim-social.php
  • src/InstagramData.php
  • uninstall.php
a4d47f9 - delete 'simsf_notification_email'

Changed files

  • uninstall.php
399de6d - v2.9.1

Changed files

  • readme.txt
  • sim-social.php
5db94b2 - fix author Uriel Wilson

Changed files

  • sim-social.php
5cf10b2 - fix code comments

Changed files

  • sim-social.php
b921fae - adds previous update date

Changed files

  • src/InstagramData.php
be624e2 - v2.9.0

Changed files

  • readme.txt
  • sim-social.php

Copy link

@david-edbot david-edbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 13 errors

⚠️ 1 warning


hashes-api-scanning skipped

Posting will continue in further review(s)

* @author Uriel Wilson
* @link https://switchwebdev.com
* ----------------------------------------------------------------------------
*/

// deny direct access.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: You must use "/**" style comments for a file comment (Squiz.Commenting.FileComment.WrongStyle).

@@ -283,8 +300,7 @@ public static function token_expire_date() {
public static function token_created_date() {
if ( self::has_refresh() ) {
$created_date = get_option( 'simsf_access_token' )['created_at'];
$date = date_i18n( get_option( 'date_format' ), $created_date);
return $date;
return date_i18n( get_option( 'date_format' ), $created_date);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).

$igtoken = array();
$igtoken['access_token'] = get_option('simsf_access_token')['access_token'];
$igtoken['reset'] = false;

# set new token value
// set new token value
update_option('simsf_token', $igtoken );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).

$igtoken = array();
$igtoken['access_token'] = get_option('simsf_access_token')['access_token'];
$igtoken['reset'] = false;

# set new token value
// set new token value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).



# new token array
// new token array
$igtoken = array();
$igtoken['access_token'] = get_option('simsf_access_token')['access_token'];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Expected 1 spaces before closing parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket).



# new token array
// new token array
$igtoken = array();
$igtoken['access_token'] = get_option('simsf_access_token')['access_token'];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).



# new token array
// new token array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).

@@ -228,15 +232,16 @@
$message = str_replace( '###SITENAME###', $blog_name, $message );
$message = str_replace( '###CREATED###', $token_created, $message );
$message = str_replace( '###EXPIRES###', $token_will_expire, $message );
$message = str_replace( '###ADMIN_EMAIL###', get_option( 'admin_email' ), $message );
$message = str_replace( '###PREVIOUS###', $previously, $message );
//$message = str_replace( '###ADMIN_EMAIL###', get_option( 'admin_email' ), $message );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: No space found before comment text; expected "// $message = str_replace( '###ADMIN_EMAIL###', get_option( 'admin_email' ), $message );" but found "//$message = str_replace( '###ADMIN_EMAIL###', get_option( 'admin_email' ), $message );" (Squiz.Commenting.InlineComment.NoSpaceBefore).

@@ -228,15 +232,16 @@
$message = str_replace( '###SITENAME###', $blog_name, $message );
$message = str_replace( '###CREATED###', $token_created, $message );
$message = str_replace( '###EXPIRES###', $token_will_expire, $message );
$message = str_replace( '###ADMIN_EMAIL###', get_option( 'admin_email' ), $message );
$message = str_replace( '###PREVIOUS###', $previously, $message );
//$message = str_replace( '###ADMIN_EMAIL###', get_option( 'admin_email' ), $message );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning: This comment is 55% valid code; is this commented out code? (Squiz.PHP.CommentedOutCode.Found).

@@ -207,7 +209,7 @@

// email message.
$message = __(
'Hi,
'Hey there!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Multi-line function call not indented correctly; expected 12 spaces but found 8 (PEAR.Functions.FunctionCallSignature.Indent).

@devuri devuri merged commit c1ee812 into master Jan 9, 2024
Copy link

@david-edbot david-edbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous scan continued.

@@ -207,7 +209,7 @@ public static function refresh_token() {

// email message.
$message = __(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Missing $domain arg (WordPress.WP.I18n.MissingArgDomain).

@@ -194,7 +196,7 @@
$user_token['expire_date'] = time() + $user_token['expires_in'];
$user_token['created_at'] = time();
$user_token['refresh'] = true;

// update token option.
update_option('simsf_access_token', $user_token );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Expected 1 spaces after opening parenthesis; 0 found (PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket).

@@ -1,22 +1,15 @@
<?php
/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: Missing short description in doc comment (Generic.Commenting.DocComment.MissingShort).

@@ -0,0 +1,2 @@
<?php
// Silence is golden.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Error: You must use "/**" style comments for a file comment (Squiz.Commenting.FileComment.WrongStyle).

@david-edbot
Copy link

GitHub API communication error. Please contact a human. (commit-ID: 8dbdfba).

@devuri devuri deleted the update-v2.9.3 branch September 5, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants