Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deployment stuck in starting for no-gitops based pipelines #5526

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix: Deployment stuck in starting for no-gitops based pipelines #5526

merged 3 commits into from
Jul 25, 2024

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Jul 19, 2024 •
edited
Loading

Description

This PR will fix: For no-gitops deployments in Devtron app, the deployment status gets stuck in Starting infinitely for a specific case

Fixes #5525

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ash-exp Ash-exp self-assigned this Jul 19, 2024
@Ash-exp Ash-exp added the enhancement New feature or request label Jul 19, 2024
@Ash-exp Ash-exp merged commit cab1354 into main Jul 25, 2024
6 checks passed
@Ash-exp Ash-exp deleted the fix-async-deployment-req-validation branch July 25, 2024 07:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamayushm iamayushm iamayushm approved these changes

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

Assignees

@Ash-exp Ash-exp

Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Deployment stuck in starting for no-gitops based pipelines
3 participants
@Ash-exp @iamayushm @kripanshdevtron