Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Created Resource Watcher Doc #5193

Merged
merged 6 commits into from
Jun 7, 2024
Merged

doc: Created Resource Watcher Doc #5193

merged 6 commits into from
Jun 7, 2024

Conversation

ashokdevtron
Copy link
Contributor

@ashokdevtron ashokdevtron commented May 28, 2024

  • RBAC added
  • Snapshots added (including gifs for better understanding)
  • Entry added in summary.md
  • Added use-cases
  • Included manifests and logs (gifs)

@ashokdevtron ashokdevtron added the documentation Improvements or additions to documentation label May 28, 2024
@ashokdevtron ashokdevtron requested a review from abhibhaw May 28, 2024 15:49
@ashokdevtron ashokdevtron self-assigned this May 28, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be adding:

  1. More usecases, practical ones (You can take help from devops team on this), as this doc is more about knowing the right usecase to use this feature then about how to.
  2. We should talk in more details about the CEL filter, how to use, what criterias to filter etc
  3. We should talk more about runtime parameters and special available parameters which can be used.
  4. We should talk about view manifest in change in resources section --> Old / New manifest and filtering / visualisation available on it

docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
@ashokdevtron ashokdevtron requested a review from abhibhaw June 6, 2024 11:48
docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
@ashokdevtron ashokdevtron requested a review from abhibhaw June 6, 2024 12:22
abhibhaw
abhibhaw previously approved these changes Jun 6, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abhibhaw
abhibhaw previously approved these changes Jun 6, 2024
docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
docs/user-guide/resource-watcher.md Show resolved Hide resolved
docs/user-guide/resource-watcher.md Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron ashokdevtron merged commit 01ad655 into main Jun 7, 2024
8 checks passed
@ashokdevtron ashokdevtron deleted the autoremediation-doc branch June 7, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants