Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Lock Deployment Config #4732

Merged
merged 5 commits into from
Mar 4, 2024
Merged

doc: Lock Deployment Config #4732

merged 5 commits into from
Mar 4, 2024

Conversation

ashokdevtron
Copy link
Contributor

No description provided.

@ashokdevtron ashokdevtron self-assigned this Mar 1, 2024
@ashokdevtron ashokdevtron changed the title doc: Doc for Lock Config doc: Lock Config Mar 1, 2024
@ashokdevtron ashokdevtron changed the title doc: Lock Config doc: Lock Deployment Config Mar 1, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. A suggestion to add this as reference at all the places in docs where we have discussed about deployment template / configs in doc. Example reference and its child pages

Copy link
Contributor

@uxarya-d uxarya-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron
Copy link
Contributor Author

This looks great. A suggestion to add this as reference at all the places in docs where we have discussed about deployment template / configs in doc. Example reference and its child pages

Done

Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashokdevtron ashokdevtron merged commit c49a6f2 into main Mar 4, 2024
5 checks passed
@ashokdevtron ashokdevtron deleted the lock-config branch March 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants