Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: active inactive user phase 1 #4589

Merged
merged 35 commits into from
Feb 8, 2024

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Jan 25, 2024

Description

Fixes #4573

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


pkg/auth/user/RoleGroupService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Show resolved Hide resolved
api/auth/user/UserRestHandler.go Outdated Show resolved Hide resolved
api/auth/user/UserRestHandler.go Outdated Show resolved Hide resolved
api/auth/user/UserRestHandler.go Outdated Show resolved Hide resolved
api/auth/user/UserRestHandler.go Outdated Show resolved Hide resolved
internal/util/ValidateUtil.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserService.go Outdated Show resolved Hide resolved
pkg/auth/user/repository/UserRepository.go Outdated Show resolved Hide resolved
Copy link

Error: The SQL file number: 220 is duplicated

api/auth/user/UserRestHandler.go Show resolved Hide resolved
api/auth/user/UserRestHandler.go Outdated Show resolved Hide resolved
api/bean/UserRequest.go Outdated Show resolved Hide resolved
internal/constants/User.go Outdated Show resolved Hide resolved
pkg/auth/user/UserAuthService.go Outdated Show resolved Hide resolved
pkg/auth/user/UserAuthService.go Outdated Show resolved Hide resolved
kartik-579
kartik-579 previously approved these changes Feb 1, 2024
Copy link

gitguardian bot commented Feb 8, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9404168 Triggered Username Password 9efa163 internal/util/ArgoUtil/ArgoClient.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Shivam-nagar23 Shivam-nagar23 merged commit cb60db0 into main Feb 8, 2024
3 of 4 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the feat-active-inactive-user-phase-1 branch February 8, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Active / Inactive user - Phase I
3 participants