fix: Remove duplicate key value in helm chart for kubelink configs #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key RUN_HELM_INSTALL_IN_ASYNC_MODE is set in templates/kubelink.yaml, so having the value is redundant and causes an error when installing via fluxcd2
benosman
requested review from
prakarsh-dt,
pawan-mehta-dt and
nishant-d
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @benosman please do this for devtron-bom.yaml file as well. We'll merge this during next release |
pawan-mehta-dt
requested changes
Dec 18, 2023
|
Thanks for reviewing, extra commit added |
pawan-mehta-dt
approved these changes
Dec 19, 2023
pawan-mehta-dt
added a commit
that referenced
this pull request
Jan 30, 2024
* Updated release-notes files * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated release notes * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated release-notes files * Updated latest image of dashboard in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Update and rename releasenotes.md to beta-releasenotes.md * Update beta-releasenotes.md * Create releasenotes.md * Updated release notes * Updated latest image of hyperion in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated release notes * fix: Remove duplicate key value in helm chart for kubelink configs (#4239) * Remove duplicate key value in kubelink configs The key RUN_HELM_INSTALL_IN_ASYNC_MODE is set in templates/kubelink.yaml, so having the value is redundant and causes an error when installing via fluxcd2 * Remove duplicate kubelink key in devtron-bom.yaml * Updated release notes * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of dashboard in installer * Updated latest image of hyperion in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of lens in installer * Updated latest image of git-sensor in installer * Updated latest image of kubewatch in installer * Updated latest image of kubelink in installer * Updated latest image of image-scanner in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of notifier in installer * Updated release notes * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of kubelink in installer * Updated latest image of dashboard in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated latest image of git-sensor in installer * Updated latest image of git-sensor in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of dashboard in installer * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of kubelink in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated release notes * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated latest image of dashboard in installer * Updated release notes * Updated release notes * Updated latest image of devtron in installer * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of ci-runner in installer * Updated latest image of image-scanner in installer * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated latest image of kubewatch in installer * Updated latest image of devtron in installer * Updated latest image of kubelink in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of devtron in installer * Updated release notes * Updated latest image of git-sensor in installer * Updated release notes * Updated release notes * Updated latest image of devtron in installer * Updated latest image of devtron in installer * Updated release notes * Updated latest image of devtron in installer * Updated latest image of dashboard in installer * Updated release notes * Updated latest image of image-scanner in installer * Updated latest image of git-sensor in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of notifier in installer * Updated latest image of git-sensor in installer * Updated release notes * Updated latest image of hyperion in installer * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated release notes * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated latest image of dashboard in installer * Update release.txt * Added support for openshift in values.yaml * Added support for openshift in devtron-bom * Created devtron-scc.yaml for openshift installations * Updated latest image of hyperion in installer * Updated latest image of dashboard in installer * Updated latest image of ci-runner in installer * Updated devtron-cm with new values * Updated values of dashboard and git-sensor * Updated new configs * Update Chart.yaml * Update devtron-installer.yaml * Update installation-script * Updated latest image of devtron in installer * Update release.txt * Updated latest image of inception in installer * Updated latest image of devtron in installer * Update release.txt * Updated release notes * Updated latest image of devtron in installer * Updated latest image of hyperion in installer * Updated release notes * Updated latest image of devtron in installer * Updated release notes * Updated release notes * Updated latest image of hyperion in installer * Updated latest image of devtron in installer * Update devtron-bom.yaml * Update installation-script * Update devtron-installer.yaml * Update Chart.yaml * Removed openshift values from devtron-bom * Update release.txt * Updated release-notes files * Update values.yaml * Update devtron-bom.yaml * Update dashboard.yaml --------- Co-authored-by: prakarsh-dt <[email protected]> Co-authored-by: Pawan Mehta <[email protected]> Co-authored-by: benosman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since argocd is not yet on the cluster at the time of installing Devtron, I'm trying to bootstrap Devtron using fluxcd v2. It installs on the cluster using regular helm just fine, but fluxcd validates the output in a stricter manner.
It complains of a duplicate key entry for RUN_HELM_INSTALL_IN_ASYNC_MODE.
In the kubelink.configs section values.yaml, a default for RUN_HELM_INSTALL_IN_ASYNC_MODE is defined as false. In templates/kubelink.yaml there is a conditional that appends that same key below, meaning in the rendered output it appears twice.
This causes fluxcd to throw the error. This issue is for a different helm chart, but it is along the same lines.
Fixes
Removed the redundant key from kubelink.configs defaults.