fix: build duration timer #842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashwatDadhich
requested review from
shivani170,
vivek-devtron,
sohel-rp and
milindk8
and removed request for
vivek-devtron
|
Kudos, SonarCloud Quality Gate passed!
|
milindk8
reviewed
Mar 20, 2023
| @@ -205,6 +205,19 @@ export const Details = ({ | |||
| [pipelineId, buildId, appId], | |||
| !!buildId && !terminalStatus.has(triggerDetails?.status?.toLowerCase()), | |||
| ) | |||
| const [durationStr, setDurationStr] = useState<string>('') | |||
There was a problem hiding this comment.
Create a common function & pass dependy array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we switch the triggered build in cases when the build is in progress then the dynamic timer below InProgress does'nt get updated. It shows the same time in every progressing build until we refresh the page.
Fixes # (841)
Type of change
How Has This Been Tested?
It has been tested loaclly as well as by deploying my code to the vm.
Checklist: