Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍀 Proposal: Using go-playground/validator to Validate Plugin Config Fields #511

Closed
iyear opened this issue May 18, 2022 · 1 comment
Closed

🍀 Proposal: Using go-playground/validator to Validate Plugin Config Fields #511

iyear opened this issue May 18, 2022 · 1 comment
Assignees
@daniel-hutao @iyear
Labels
enhancement New feature or request
Milestone
dtm-v0.6.0

Comments

@iyear
Copy link
Member

iyear commented May 18, 2022

What would you like to add? Why is this needed?

Currently for each field we manually validate, I think we can import a new dependency, https://github.com/go-playground/validator

we can just write tag in the fields of the struct, and the validation I proposed in #482 can be registered directly as tag to use.
@iyear iyear changed the title 🍀 Proposal: Using go-playground/validator to validate plugin config fields 🍀 Proposal: Using go-playground/validator to Validate Plugin Config Fields May 18, 2022
@daniel-hutao
Copy link
Member

@iyear Cooooooool proposal! I agree to use this tool!

@daniel-hutao daniel-hutao added the enhancement New feature or request label May 18, 2022
@daniel-hutao daniel-hutao added this to the dtm-v0.6.0 milestone May 18, 2022
iyear added a commit to iyear/devstream that referenced this issue May 18, 2022
@iyear
refactor: use validator to validate fields devstream-io#511
4a0e0f8
@iyear iyear mentioned this issue May 18, 2022
Merged
@iyear iyear closed this as completed May 19, 2022
@IronCore864 IronCore864 mentioned this issue May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-hutao daniel-hutao

@iyear iyear

Labels
enhancement New feature or request
Projects
None yet
Milestone
dtm-v0.6.0
Development

No branches or pull requests
2 participants
@daniel-hutao @iyear