feature: adding api_base option #96
Conversation
|
Thanks for your PR. Can I ask why this dynamic |
|
This is a bug of Intercom, some Internet Service Providers in Vietnam are not connecting to Intercom. Intercom added |
|
I see, but I would like a url to some official documentation so I can confirm this. Could you add some tests to make sure there are no side effects? |
|
@doankhoi Have you got any update on this? Otherwise I'm inclined to close this PR. |
…i/react-use-intercom into pr/doankhoi/96
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.4.9 to 11.0.0. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v10.4.9...v11.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.0 to 11.0.2. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v11.0.0...v11.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [husky](https://github.com/typicode/husky) from 4.2.5 to 4.3.0. - [Release notes](https://github.com/typicode/husky/releases) - [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md) - [Commits](typicode/husky@v4.2.5...v4.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 11.0.2 to 11.0.4. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v11.0.2...v11.0.4) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [cypress](https://github.com/cypress-io/cypress) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Commits](cypress-io/cypress@v5.1.0...v5.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.0.2...v4.0.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [tsdx](https://github.com/formium/tsdx) from 0.13.3 to 0.14.0. - [Release notes](https://github.com/formium/tsdx/releases) - [Commits](jaredpalmer/tsdx@v0.13.3...v0.14.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…i/react-use-intercom into pr/doankhoi/96
|
Saw another related issue for a simular Intercom solution: https://github.com/intercom/intercom-rails/pull/329/files |
|
Hello ! Is this fix still up-to-date ? I tried to use the apiBase prop without success. It seems that the official API Doc has changed slightly, introducing a discrepancy between react-use-intercom, and Intercom. The documentation ( https://developers.intercom.com/installing-intercom/docs/basic-javascript ) gives 3 possible values for Regional Location | API Base to Set Hence I don't think the react-use-intercom feature is up-to-date. See current explanation about IntercomProvider's props I have tried both To bypass that problem, I need to delete react-use-intercom and use the traditional HTML Intercom implementation. Thanks ! |
|
Hi, indeed the according documentation is outdated, but the functionality hasn't changed. You can still set the |
|
It does not work for me as well. Removing the react-use-intercom package from my project. |
No description provided.