feat(issue-403): Make sure to use project message bus instead of appl… #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication message bus + centralization of subscription to the message bus
|
Hello @stephanj this one is a pretty big change so it needs to be tested (seems ok on my side but i'm not sure to see everything) : in a glimpse --> project level message bus usage , centralization of subscription for panels elements in devoxxWIndowToolContent (maybe it's a bad idea i can rollback this one) and Sync publication at project level Let me know if you see something bad (design and tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to use project message bus instead of application message bus + centralization of subscription to the message bus + modification of syncPublisher calls to publish at project level