-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support Python 3.12 #458
Open
okainov
wants to merge
2
commits into
devopshq:master
Choose a base branch
from
okainov:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -422,7 +422,7 @@ def quote_url(url): | |
return quoted_url | ||
|
||
|
||
class _ArtifactoryFlavour(pathlib._Flavour): | ||
class _ArtifactoryFlavour: | ||
""" | ||
Implements Artifactory-specific pure path manipulations. | ||
I.e. what is 'drive', 'root' and 'path' and how to split full path into | ||
|
@@ -440,7 +440,6 @@ class _ArtifactoryFlavour(pathlib._Flavour): | |
sep = "/" | ||
altsep = "/" | ||
has_drv = True | ||
pathmod = pathlib.posixpath | ||
is_supported = True | ||
|
||
def _get_base_url(self, url): | ||
|
@@ -1501,10 +1500,16 @@ class ArtifactoryPath(pathlib.Path, PureArtifactoryPath): | |
# see changes in pathlib.Path, slots are no more applied | ||
# https://github.com/python/cpython/blob/ce121fd8755d4db9511ce4aab39d0577165e118e/Lib/pathlib.py#L952 | ||
_accessor = _artifactory_accessor | ||
parser = _ArtifactoryFlavour() | ||
else: | ||
# in 3.9 and below Pathlib limits what members can be present in 'Path' class | ||
__slots__ = ("auth", "verify", "cert", "session", "timeout") | ||
|
||
|
||
def __init__(self, *args, **kwargs): | ||
# supplying keyword arguments to pathlib.PurePath is deprecated | ||
return super().__init__(*args) | ||
|
||
def __new__(cls, *args, **kwargs): | ||
""" | ||
pathlib.Path overrides __new__ in order to create objects | ||
|
@@ -1514,6 +1519,10 @@ def __new__(cls, *args, **kwargs): | |
only then add auth information. | ||
""" | ||
obj = pathlib.Path.__new__(cls, *args, **kwargs) | ||
|
||
if sys.version_info.major == 3 and sys.version_info.minor >= 12: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should not have version specific behaviour if this can be avoided. If positional arguments can be passed in all supported earlier versions, then we should be doing it for all versions. Why is |
||
# supplying keyword arguments to pathlib.PurePath is deprecated | ||
obj.__init__(*args) | ||
|
||
cfg_entry = get_global_config_entry(obj.drive) | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we should not silently suppress the kwargs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We should just axe this override, as you're passing via args below anyway.