Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker_api_version of repo #361

Merged
merged 3 commits into from
Aug 15, 2022
Merged

fix docker_api_version of repo #361

merged 3 commits into from
Aug 15, 2022

Conversation

donhui
Copy link
Contributor

@donhui donhui commented Aug 12, 2022

fix #333

beliaev-maksim
beliaev-maksim requested changes Aug 12, 2022
View reviewed changes
Copy link
Member

@beliaev-maksim beliaev-maksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I am not mistaken, then this feature is not available in all versions of artifactory. Then, if user uses some old version it may get broken. Adding None should help

dohq_artifactory/admin.py Outdated Show resolved Hide resolved
dohq_artifactory/admin.py Outdated Show resolved Hide resolved
donhui
donhui commented Aug 12, 2022
View reviewed changes
dohq_artifactory/admin.py Outdated Show resolved Hide resolved
@donhui
Copy link
Contributor Author

donhui commented Aug 12, 2022

@beliaev-maksim
Thanks for your suggestion, I hava updated the code.

@allburov allburov merged commit 4f36c36 into devopshq:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allburov allburov allburov approved these changes

@beliaev-maksim beliaev-maksim beliaev-maksim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Docker API Version
3 participants
@donhui @allburov @beliaev-maksim