Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_stat_json using wrong url #127

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

fuzzmz
Copy link
Contributor

@fuzzmz fuzzmz commented Dec 4, 2019

The artifact upload process fails because when we create the
Artifactory Storage API request we duplicate the / between artifactory
and api.

Let's say we're trying to upload an artifact to
http://my-artifactory/artifactory/upload-dest .
When we reach get_stat_json and process the url, instead of getting
http://my-artifactory/artifactory/api/storage/upload-dest
we get http://my-artifactory/artifactory//api/storage/upload-dest

This in turn returns a 500 Repo key cannot be empty error and fails
the upload.

Fixes #126

The artifact upload process fails because when we create the
Artifactory Storage API request we duplicate the / between artifactory
and api.

Let's say we're trying to upload an artifact to
http://my-artifactory/artifactory/upload-dest .
When we reach get_stat_json and process the url, instead of getting
http://my-artifactory/artifactory/api/storage/upload-dest
we get http://my-artifactory/artifactory//api/storage/upload-dest

This in turn returns a 500 Repo key cannot be empty error and fails
the upload.
@allburov
Copy link
Member

allburov commented Dec 5, 2019

@fuzzmz thanks!

@allburov allburov merged commit d42edae into devopshq:develop Dec 5, 2019
@fuzzmz fuzzmz deleted the fix-artifact-upload-failure branch December 5, 2019 11:23
@fuzzmz
Copy link
Contributor Author

fuzzmz commented Dec 9, 2019

@allburov, any ETA on a new version making it to pypi? I'm interesting in this patch and the one for #128.

We can live with our own internal fork, but I'd rather have it based on the official one.

@allburov
Copy link
Member

@fuzzmz dohq-artifactory 0.7.297 is available on pypi with the fix

@fuzzmz
Copy link
Contributor Author

fuzzmz commented Dec 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Artifact upload fails with RuntimeError 500, Repo key cannot be empty
2 participants