Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArtifactoryPath.set_properties should use Update item properties API instead #65

Closed
gangefors opened this issue May 21, 2019 · 3 comments · Fixed by #298
Closed

ArtifactoryPath.set_properties should use Update item properties API instead #65

gangefors opened this issue May 21, 2019 · 3 comments · Fixed by #298
Assignees

Comments

@gangefors
Copy link

There is an issue with using the Set item properties API in artifactory. When setting a lot of properties you can run into the issue where the URI becomes too long.

If set_properties use the Update item properties API no such issue exists since it takes json data as input with a PATCH request.

https://www.jfrog.com/confluence/display/RTF/Artifactory+REST+API#ArtifactoryRESTAPI-UpdateItemProperties

The request can add, update and delete properties which means that it can basically do all actions one wants to do with properties.

Should a new method be implemented (update_properties) or should set_properties be rewritten to use the update item properties API? Because I'm willing to do a PR for this as long as I know how you want it implemented.
Using a new method will mirror the API endpoins that exist. But updating set_properties will remove the issue with URI too long.

@allburov allburov added Help Wanted We will be glad if somebody proposes a solution via PR good first issue labels Nov 16, 2020
@beliaev-maksim beliaev-maksim self-assigned this Oct 1, 2021
beliaev-maksim added a commit to beliaev-maksim/artifactory that referenced this issue Oct 1, 2021
@beliaev-maksim beliaev-maksim added In-Progress work on the feature has started and removed good first issue Help Wanted We will be glad if somebody proposes a solution via PR labels Oct 1, 2021
@beliaev-maksim beliaev-maksim linked a pull request Oct 1, 2021 that will close this issue
beliaev-maksim added a commit to beliaev-maksim/artifactory that referenced this issue Oct 6, 2021
beliaev-maksim added a commit to beliaev-maksim/artifactory that referenced this issue Oct 8, 2021
@kvecchione
Copy link

This update is causing an issue for us, recursive=0 is set on the PATCH but properties are still being set recursively when that is not desired.

@beliaev-maksim
Copy link
Member

@kvecchione
please open a new issue and provide a minimum reproducible snippet

@beliaev-maksim beliaev-maksim removed the In-Progress work on the feature has started label Dec 21, 2021
@kvecchione
Copy link

#326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants