Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE REQUEST: adding st_size attribute to ArtifactoryFileStat #453

Closed
doronz88 opened this issue Sep 22, 2024 · 3 comments
Closed

FEATURE REQUEST: adding st_size attribute to ArtifactoryFileStat #453

doronz88 opened this issue Sep 22, 2024 · 3 comments

Comments

@doronz88
Copy link
Contributor

doronz88 commented Sep 22, 2024 •
edited
Loading

Hi,

In many parts of my code I use ArtifactoryPath the same as Path. However, the Path('').stat() has a st_size attribute, while ArtifactoryPath('').stat() has only a size attribute. What do you think of adding a st_size attribute to ArtifactoryFileStat aswell, so code using both paths can access them both seamlessly?

If you agree, I can create a PR for it.

Also, thanks for taking the gloves off and cotinuing this project! ❤️
@allburov
Copy link
Member

If you agree, I can create a PR for it.

Good idea, it'd be great!

doronz88 added a commit to doronz88/artifactory that referenced this issue Sep 23, 2024
@doronz88
artifactory: add st_size to ArtifactoryFileStat (devopshq#453)
adeb8b2
allburov pushed a commit that referenced this issue Sep 23, 2024
@doronz88
artifactory: add st_size to ArtifactoryFileStat (#453) (#454)
c0d788c
@allburov
Copy link
Member

Thank you for your contribution! 🫶

https://github.com/devopshq/artifactory/releases/tag/0.10.1
We're fixing the action issue, hopefully soon will be in pypi 🤞 https://github.com/devopshq/artifactory/actions/runs/10990572076/job/30511061714

@allburov
Copy link
Member

done! https://pypi.org/project/dohq-artifactory/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allburov @doronz88