Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#894: Fix remaining bug in ide.bat #964

Merged
merged 5 commits into from
Jan 21, 2025
Merged

#894: Fix remaining bug in ide.bat #964

merged 5 commits into from
Jan 21, 2025

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Jan 21, 2025 •
edited
Loading

This PR fixes remaining bugs of same issue in PR's #902 and #932

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12884127009

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.126%
Totals Coverage Status
Change from base Build 12876082916: 0.0%
Covered Lines: 7080
Relevant Lines: 10016
💛 - Coveralls

@alfeilex alfeilex changed the title #894: Fix idebat.bat #894: Fix ide.bat Jan 21, 2025
@hohwille hohwille added bugfix windows specific for Microsoft Windows OS labels Jan 21, 2025
@alfeilex alfeilex marked this pull request as ready for review January 21, 2025 09:49
@hohwille hohwille added the CMD Support in Windows CMD/MSDOS via ide.bat label Jan 21, 2025
@alfeilex alfeilex changed the title #894: Fix ide.bat #894: Fix remaining bug in ide.bat Jan 21, 2025
hohwille
hohwille approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for the fast fix and great that you found and fixed the same bug pattern also in 2 other places.

@hohwille hohwille merged commit 8484189 into devonfw:main Jan 21, 2025
4 checks passed
@hohwille hohwille added this to the release:2025.01.001 milestone Jan 21, 2025
@alfeilex alfeilex deleted the #894-fix-idebat branch January 21, 2025 17:16
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@alfeilex alfeilex

Labels
bugfix CMD Support in Windows CMD/MSDOS via ide.bat reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. windows specific for Microsoft Windows OS
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.01.001
Development

Successfully merging this pull request may close these issues.
3 participants
@alfeilex @coveralls @hohwille