Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#856: Made gcviewer start in background #896

Merged
merged 8 commits into from
Dec 13, 2024
Merged

#856: Made gcviewer start in background #896

merged 8 commits into from
Dec 13, 2024

Conversation

WorkingAmeise
Copy link
Contributor

@WorkingAmeise WorkingAmeise commented Dec 12, 2024 •
edited
Loading

Fixes #856

  • Changed ProcessMode of gcviewer commandlet to BACKGROUND_SILENT
  • Added Changelog message

devonfw#856: Made gcviewer start in background
0d4546b 
Changed ProcessMode of gcviewer commandlet to BACKGROUND_SILENT
Added Changelog message
@WorkingAmeise WorkingAmeise self-assigned this Dec 12, 2024
@WorkingAmeise WorkingAmeise added gcviewer GUI to visualize logs of Java Garbage Collector process executing external programs (ProcessContext) labels Dec 12, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12312606207

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 67.429%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/gcviewer/GcViewer.java 2 16.67%
Totals Coverage Status
Change from base Build 12302719390: 0.0%
Covered Lines: 6653
Relevant Lines: 9527
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added missing return to the changelog.

hohwille
hohwille approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WorkingAmeise thanks for your PR. Your implementation is fine and ready for merge 👍

WorkingAmeise added 2 commits December 13, 2024 09:58
devonfw#856: Fixed link in CHANGELOG
941636f 
Changed Link from "full list of changes" to point to the fitting release
devonfw#856: CHANGELOG link update
5fcc654
@hohwille hohwille added this to the release:2024.12.002 milestone Dec 13, 2024
@hohwille hohwille merged commit 83acd3a into devonfw:main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

@WorkingAmeise WorkingAmeise

Labels
gcviewer GUI to visualize logs of Java Garbage Collector process executing external programs (ProcessContext)
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.002
Development

Successfully merging this pull request may close these issues.

gcviewer runs in foreground
4 participants
@WorkingAmeise @coveralls @hohwille @jan-vcapgemini