Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#851: replaced script with binary #852

Merged

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented Dec 6, 2024

Fixes: #851

Implements:

  • replaced idea.sh with idea
  • replaced studio.sh with studio
  • added checks for old versions to fallback to idea/studio.sh

replaced idea.sh with idea
replaced studio.sh with studio
@jan-vcapgemini jan-vcapgemini self-assigned this Dec 6, 2024
@salimbouch
Copy link
Contributor

LGTM, you have a build error tho

added checks for idea and studio files as well als idea.sh and studio.sh
@jan-vcapgemini jan-vcapgemini added intellij IntelliJ IDE from Jet-Brains android-studio Android Studio IDE from Jet-Brains labels Dec 9, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12237539704

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 67.069%

Totals Coverage Status
Change from base Build 12236799868: 0.03%
Covered Lines: 6613
Relevant Lines: 9513

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for the PR and fixing these problems. Great work 👍
I am quite confident that we now have found a good approach. This will also fix #808

Only if Jetbrains ships many more releases and every time changes things here and we reach a state where our code needs to consider the INTELLIJ_VERSION to determine the binary name then we should have stayed with the old approach.
In the end Jetbrains is already going in the direction we prefer only that the tool is called intellij but they use the internal name idea and that is not the binary name.
Assuming on windows there would also be a idea.exe instead of idea64.exe we would not need such quirks.

@hohwille hohwille added this to the release:2024.12.001 milestone Dec 9, 2024
@hohwille hohwille linked an issue Dec 9, 2024 that may be closed by this pull request
@hohwille hohwille merged commit b8c6705 into devonfw:main Dec 9, 2024
4 checks passed
@jan-vcapgemini jan-vcapgemini deleted the feature/851-replace-idea-start-scripts branch December 9, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-studio Android Studio IDE from Jet-Brains intellij IntelliJ IDE from Jet-Brains
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Replace idea script with native binary devonfw-ide regression: cannot launch intellij
4 participants