-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#851: replaced script with binary #852
#851: replaced script with binary #852
Conversation
replaced idea.sh with idea replaced studio.sh with studio
LGTM, you have a build error tho |
cli/src/main/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudio.java
Outdated
Show resolved
Hide resolved
added checks for idea and studio files as well als idea.sh and studio.sh
Pull Request Test Coverage Report for Build 12237539704Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jan-vcapgemini thanks for the PR and fixing these problems. Great work 👍
I am quite confident that we now have found a good approach. This will also fix #808
Only if Jetbrains ships many more releases and every time changes things here and we reach a state where our code needs to consider the INTELLIJ_VERSION to determine the binary name then we should have stayed with the old approach.
In the end Jetbrains is already going in the direction we prefer only that the tool is called intellij
but they use the internal name idea
and that is not the binary name.
Assuming on windows there would also be a idea.exe
instead of idea64.exe
we would not need such quirks.
Fixes: #851
Implements: