#759: upgrade settings commandlet #820

leonrohne27 · 2024-11-28T19:12:34Z

Fixes: #759

Implements:

all devon.properties are renamed to ide.properties. In case both files exists in the same directory, devon.properties gets merged into ide.properties. ide.properties has priority here.
duplicated variables in the same ide.properties file are being removed
If variable DEVON_IDE_CUSTOM_TOOLS exists, it is converted into a custom-tools.json file in settings
if settings/devon folder exists, it is renamed to settings/templates, if settings/projects folder exists, it is renamed to settings/repositories
recursively traverses all files in settings/workspace and settings/*/workspace and replacse all known IdeVariables from CURLY into ANGLED syntax and legacy variable names are replaced with their new names.
for all .xml files that do not contain the XML namespace of our merger, we print a warning with the filepath saying that this file is most-likely outdated and print a link to a documentation page about this settings migration feature
documentation page with small instructions for those who migrate from devonfw-ide to IDEasy
if a replacement-patterns.properties is found in a workspace folder a warning will be logged if the file is not empty and the file will be deleted.
if settings/ide.properties does not contain IDE_VARIABLE_SYNTAX_LEGACY_SUPPORT_ENABLED=false it will be added.

Added the command cd to the shell commandlet that allows the user to switch the directory inside the ide shell

…dlet

…dlet.java Co-authored-by: jan-vcapgemini <[email protected]>

added current working directory path to prompt name improved existing directory check adjusted exit codes

removed whitespace from ide prompt

cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java

cli/src/main/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFile.java

cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java

cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java

cli/src/main/java/com/devonfw/tools/ide/merge/FileMerger.java

cli/src/main/java/com/devonfw/tools/ide/merge/JsonMerger.java

cli/src/main/java/com/devonfw/tools/ide/merge/WorkspaceMerger.java

cli/src/main/java/com/devonfw/tools/ide/repo/CustomToolMetadata.java

cli/src/main/java/com/devonfw/tools/ide/repo/CustomToolsJsonMapper.java

jan-vcapgemini

LGTUS. Co-Reviewed by: @salimbouch; @julia-cap
We've added some questions and CRs to resolve before the merge.

added default implementation for remove method

removed unnecessary test files

jan-vcapgemini

Removed unnecessary test resource files.

fixed map eclipse legacy editions added private modifier

cleanup fixed typo

jan-vcapgemini

Thanks for resolving the CRs. LGTM.

removed remove method from EnvironmentVariables

cleanup

Kian and others added 30 commits October 2, 2024 16:17

devonfw#765: Fix typos in DoD asciidoc

7af9fc5

Merge branch 'main' of https://github.com/KianRolf/IDEasy

aeae1dd

Merge branch 'main' of https://github.com/KianRolf/IDEasy

e520d16

Merge branch 'main' of https://github.com/KianRolf/IDEasy

29403d3

Merge branch 'main' of https://github.com/KianRolf/IDEasy

5bff5eb

Merge branch 'main' of https://github.com/KianRolf/IDEasy

890c107

Merge branch 'main' of https://github.com/KianRolf/IDEasy

c55af62

devonfw#737: Added cd command to shell commandlet

3be67d0

Added the command cd to the shell commandlet that allows the user to switch the directory inside the ide shell

Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…

60f2e8a

…dlet

Merge branch 'main' of https://github.com/KianRolf/IDEasy

5224bf9

Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…

02cdeb0

…dlet

Merge branch 'main' of https://github.com/KianRolf/IDEasy

d925977

Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…

2d41161

…dlet

Merge branch 'main' of https://github.com/KianRolf/IDEasy

4a8f60b

Merge branch 'main' of https://github.com/KianRolf/IDEasy

1a6cdb8

Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…

bad672f

…dlet

Merge branch 'main' of https://github.com/KianRolf/IDEasy

f79c030

Merge branch 'main' of https://github.com/KianRolf/IDEasy

3d2b190

Merge branch 'main' of https://github.com/KianRolf/IDEasy

e1854bb

Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…

b85ca18

…dlet

Update cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellComman…

51dd0c2

…dlet.java Co-authored-by: jan-vcapgemini <[email protected]>

Update cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellComman…

0bd754c

…dlet.java Co-authored-by: jan-vcapgemini <[email protected]>

Merge branch 'main' of https://github.com/KianRolf/IDEasy

0302acf

devonfw#737: optimized cd command

1af2948

added current working directory path to prompt name improved existing directory check adjusted exit codes

devonfw#737: optimized cd command

ec4d5f6

removed whitespace from ide prompt

devonfw#737: Added Changelog entry

06e9b8a

devonfw#759:

4602866

kian ist der best

7bb5674

devonfw#759: listchildrenrecursive

50b9fb2

devonfw#759: rename

07ae66e

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java Outdated Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/commandlet/UpgradeSettingsCommandlet.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFile.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFile.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/environment/EnvironmentVariablesPropertiesFile.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java Outdated Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java Outdated Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/merge/FileMerger.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/merge/JsonMerger.java Outdated Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/merge/WorkspaceMerger.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/repo/CustomToolMetadata.java Show resolved Hide resolved

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

cli/src/main/java/com/devonfw/tools/ide/repo/CustomToolsJsonMapper.java Show resolved Hide resolved

jan-vcapgemini requested changes Jan 13, 2025

View reviewed changes

jan-vcapgemini added 3 commits January 13, 2025 15:57

devonfw#759: implemented requested changes

0056345

added default implementation for remove method

devonfw#759: cleanup

2632801

removed unnecessary test files

devonfw#759: cleanup

488d5b9

removed unnecessary test files

jan-vcapgemini reviewed Jan 13, 2025

View reviewed changes

jan-vcapgemini and others added 5 commits January 13, 2025 16:18

devonfw#759: implemented requested changes

b4660a6

fixed map eclipse legacy editions added private modifier

devonfw#759: implemented requested changes

b7b0d10

cleanup fixed typo

devonfw#759: review rework (JavaDoc)

3db4692

Merge branch 'main' into implement/759-UpgradeSettingsCommandlet

0eac439

Merge branch 'main' into implement/759-UpgradeSettingsCommandlet

e2ff421

jan-vcapgemini approved these changes Jan 14, 2025

View reviewed changes

jan-vcapgemini added 2 commits January 14, 2025 10:22

devonfw#759: implemented requested changes

0ebdb62

removed remove method from EnvironmentVariables

devonfw#759: implemented requested changes

115768c

cleanup

This was referenced Jan 14, 2025

Optimize UpgradeSettings updateLegacyFolder to use FileAccess #929

Open

Refactor JsonPrettyPrinter to be usable in CustomToolJson #930

Open

hohwille merged commit 241ce06 into devonfw:main Jan 14, 2025
4 checks passed

hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jan 14, 2025

hohwille mentioned this pull request Jan 19, 2025

Create devonfw-ide to IDEasy settings migration guide #740

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#759: upgrade settings commandlet #820

#759: upgrade settings commandlet #820

leonrohne27 commented Nov 28, 2024

jan-vcapgemini left a comment •

edited

Loading

jan-vcapgemini left a comment •

edited

Loading

jan-vcapgemini left a comment

#759: upgrade settings commandlet #820

#759: upgrade settings commandlet #820

Conversation

leonrohne27 commented Nov 28, 2024

Fixes: #759

Implements:

jan-vcapgemini left a comment • edited Loading

Choose a reason for hiding this comment

jan-vcapgemini left a comment • edited Loading

Choose a reason for hiding this comment

jan-vcapgemini left a comment

Choose a reason for hiding this comment

jan-vcapgemini left a comment •

edited

Loading

jan-vcapgemini left a comment •

edited

Loading