#589: Fix NLS bundles for Linux and MacOS #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfeilex
changed the title
Pull Request Test Coverage Report for Build 11940700610Details
💛 - Coveralls |
hohwille
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
@alfeilex thank you for finding this solution and verifying that it fixes the error on Linux. Also thanks for providing the links and explanations. I am very confident that this will also fix the problem on MacOS. 🥇
Therefore I propose to merge this now and test the next SNAPSHOT release on MacOS. I can do that on my MacBook.
hohwille
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #589
I removed
<arg>-H:IncludeResources="nls/.*"</arg>because it is an experimental feature and doesn't work on Linux and MacOS, see 851cdb3A working solution for Windows and Linux is to include a
resource-config.jsonlike b5da1d4Related docs:
https://www.graalvm.org/jdk21/reference-manual/native-image/metadata/#resource-metadata-in-json
This configuration also works for the latest GraalVM JDK Version (23) if we decide to upgrade our version in the workflow.
Tested on Ubuntu 20.04.01 LTS
It still need to be tested on MacOS