Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#754: bullet proof solution for processable output and logging #777

Merged
merged 5 commits into from
Nov 21, 2024
Merged

#754: bullet proof solution for processable output and logging #777

merged 5 commits into from
Nov 21, 2024

Conversation

hohwille
Copy link
Member

fixed #754

  • added IdeLogLevel.PROCESSABLE
  • moved lots of features to AbstractIdeSubLogger
  • added IdeLogListener that receives log events
  • added IdeLogListenerBuffer that collects log events as IdeLogEntry (what was moved from test to main)
  • consolidated IdeSubLogger implementations.
  • IdeSubLoggerOut now is always used can be enabled or disabled (removed IdeSubLoggerNone)
  • IdeSubLoggerOut and IdeLogListenerBuffer are used together to collect log-events until activateLogging() is called what will replay the buffered events to the now properly configured logger that can then decide which log-events to log or discard.
  • extended IdeLogEntry with additional properties like rawMessage, args, and error for advanced testing and assertion capabilities
  • modified all processable output commandlets to use the new PROCESSABLE log-level
  • fixed according tests
  • etc.

@hohwille hohwille added enhancement New feature or request commandlet logging labels Nov 19, 2024
@hohwille hohwille added this to the release:2024.12.001 milestone Nov 19, 2024
@hohwille hohwille self-assigned this Nov 19, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11933031282

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 92 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.2%) to 67.438%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/log/IdeLogLevel.java 2 91.67%
com/devonfw/tools/ide/commandlet/VersionGetCommandlet.java 2 88.64%
com/devonfw/tools/ide/commandlet/VersionCommandlet.java 2 62.5%
com/devonfw/tools/ide/commandlet/EditionGetCommandlet.java 2 88.64%
com/devonfw/tools/ide/commandlet/ContextCommandlet.java 3 74.47%
com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java 5 83.87%
com/devonfw/tools/ide/log/IdeLogExceptionDetails.java 7 36.0%
com/devonfw/tools/ide/step/StepImpl.java 11 83.49%
com/devonfw/tools/ide/log/IdeSubLoggerOut.java 14 26.47%
com/devonfw/tools/ide/log/AbstractIdeSubLogger.java 21 60.82%
Totals Coverage Status
Change from base Build 11932927810: 0.2%
Covered Lines: 6455
Relevant Lines: 9233
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTUs. Co-Reviewed by: @alfeilex ,@nmCapG, @leonrohne27, @KianRolf, @WorkingAmeise

@hohwille hohwille merged commit d3dfb95 into devonfw:main Nov 21, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Dec 3, 2024
@hohwille hohwille mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
commandlet enhancement New feature or request logging reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.001
Development

Successfully merging this pull request may close these issues.

Again messages break processable command output
3 participants
@hohwille @coveralls @jan-vcapgemini