Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#734: Improve Process Result Model #773

Merged
merged 36 commits into from
Jan 16, 2025
Merged

#734: Improve Process Result Model #773

merged 36 commits into from
Jan 16, 2025

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Nov 19, 2024 •
edited
Loading

Fixes: #734

This PR improves the process result capturing of stdout and stderr output by preserving the order of the output.

@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12805638817

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 67.846%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/process/ProcessResultImpl.java 6 77.5%
com/devonfw/tools/ide/process/ProcessContextImpl.java 24 79.73%
Totals Coverage Status
Change from base Build 12770927937: 0.02%
Covered Lines: 6967
Relevant Lines: 9902
💛 - Coveralls

@alfeilex alfeilex marked this pull request as ready for review December 11, 2024 14:19
hohwille
hohwille reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your PR. Already on its way and looking good. Thanks 👍
I left some review comments for improvement. Please have a look.

@hohwille hohwille added this to the release:2025.01.001 milestone Dec 20, 2024
@alfeilex
Copy link
Member Author

alfeilex commented Jan 7, 2025

Finally, I chose ConcurrentLinkedQueue since the runtime is similar for all approaches and this approach is non-blocking which could be more efficient when handling with more lines of logs. Further, with the added sleep between each echo in the test file, also no more failing tests occur.

hohwille
hohwille approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for bringing this PR to perfection. Great work! 👍
If you address your own review comment that I also commented with a hint, we can finally merge this.

hohwille
hohwille approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks - now great and ready for merge 👍

@hohwille hohwille merged commit 34b5142 into devonfw:main Jan 16, 2025
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jan 21, 2025
@alfeilex alfeilex deleted the #734-improve-process-result branch January 22, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@alfeilex alfeilex

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.01.001
Development

Successfully merging this pull request may close these issues.

Improve ProcessResult: get out and err in order
4 participants
@alfeilex @coveralls @hohwille @jan-vcapgemini