#404: logging concept

[KianRolf]

draft pr for: #404

Attempt to create custom slf4j provider by implementing 3 slf4j interfaces. Will result in the following error

[coveralls]

Pull Request Test Coverage Report for Build 13009540527

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 122 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.04%) to 68.41%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/log/IdeSubLoggerOut.java	1	85.29%
com/devonfw/tools/ide/cli/Ideasy.java	17	56.52%
com/devonfw/tools/ide/context/AbstractIdeContext.java	104	59.4%

Totals
Change from base Build 12995336297:	-0.04%
Covered Lines:	7307
Relevant Lines:	10289

---

💛 - Coveralls

[hohwille]

This PR is still in New state so I never looked at it before.
Most probably Jan-V. wanted to do a team review and probably complete things together with Kian.
Anyway, here is my Review feedback:

• Great that you found this trick with META-INF/services to control which implementation SLF4J will use. This is the concept used by Java ServiceLoader. A lot of Java developers with years of development experience have never heard of such things before so it is great that you figured this out :)
• You properly found a way to provide our own logger implementation for SLF4J 👍
• Please add JavaDoc: Your methods are already annotated with @Override - that is great so nothing is to be done here but your classes should have a JavaDoc:

/**
 * Implementation of {@Logger} for this project. Allows logging to the console with coloured output.
 */
public class TestLogger implements Logger {

BTW: you should avoid fully-qualified types in your code and use import statements instead (only use fully-qualified types when necessary because you are using 2 different types with the same simple name).

• Further, you should rename this class: It is located in src/main/java and that is correct, because it is to be used for the productive usage by the end-user. The name TestLogger implies that is will only be used for testing. A better name could be e.g. IdeLoggerAdapter. or IdeSlf4jLoggerImpl.
• Finally, your logger implementation is more or less empty. I guess your are fully aware of that but since the PR is not in draft state, I just wanted to explicitly mention this because here comes the tricky part: You need to delegate to IdeLogger and do additional things. Therefore I assume this PR cannot be finished by you and someone would need to take over.

[jan-vcapgemini]

Closing and continuing in #1017