Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#727: allow fallback to edition independent dependencies.json #728

Merged

Conversation

hohwille
Copy link
Member

fixes #727

  • allow fallback to edition independent dependencies.json
  • added test since there was no test for this
  • improve test-infrastructure

@hohwille hohwille added enhancement New feature or request test related to testing and QA urls ide-urls repo and related processes and features dependency Tool dependencies (if tool A requires tool B) labels Oct 29, 2024
@hohwille hohwille added this to the release:2024.11.001 milestone Oct 29, 2024
@hohwille hohwille self-assigned this Oct 29, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11595623753

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 87 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 66.746%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 2 86.19%
com/devonfw/tools/ide/url/model/file/json/ToolDependencies.java 4 78.38%
com/devonfw/tools/ide/url/model/folder/UrlEdition.java 7 20.0%
com/devonfw/tools/ide/context/AbstractIdeContext.java 74 60.0%
Totals Coverage Status
Change from base Build 11580911301: 0.03%
Covered Lines: 6290
Relevant Lines: 9081

💛 - Coveralls

@hohwille
Copy link
Member Author

hohwille commented Nov 1, 2024

I dont want to block this PR further since all is ready and quite obvious.
Team review feedback is still welcome even after merge and I can create a follow up PR if required...

@hohwille hohwille merged commit 15910e5 into devonfw:main Nov 4, 2024
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Tool dependencies (if tool A requires tool B) enhancement New feature or request reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. test related to testing and QA urls ide-urls repo and related processes and features
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add support to for dependencies.json for all editions of a tool
3 participants