Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devonfw/ide-urls#17: fix UrlUpdater to auto-remove broken URLs and allow self-repair #681

Merged

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Oct 7, 2024

fixes devonfw/ide-urls#17

or at least tries to fix the problem. Releases that are gone cannot come back but they will now be deleted if 404 have been detected for 14+ days.
If no valid URL remains for a version the entire version will be gone.
Therefore it will be recreated if it still exists (e.g. on different mirror).

I found and fixed many evil bugs and spent a long time debugging this mess...

@hohwille hohwille added urls ide-urls repo and related processes and features eclipse related to Eclipse IDE labels Oct 7, 2024
@hohwille hohwille added this to the urls milestone Oct 7, 2024
@hohwille hohwille self-assigned this Oct 7, 2024
@hohwille
Copy link
Member Author

hohwille commented Oct 8, 2024

Tests still failing:

[ERROR] Failures:
[ERROR] UrlUpdaterReportTest.testReportAfterVersionForOsRemoved:104
expected: mocked/mocked:addVersionSuccess=1, addVersionFailure=0, verificationSuccess=7, verificationFailure=8
but was: mocked/mocked:addVersionSuccess=1, addVersionFailure=0, verificationSuccess=2, verificationFailure=2
[ERROR] UrlUpdaterReportTest.testReportAfterVersionsForRemovedAndReversedUrlResponses:143
expected: mocked/mocked:addVersionSuccess=1, addVersionFailure=0, verificationSuccess=6, verificationFailure=6
but was: mocked/mocked:addVersionSuccess=1, addVersionFailure=0, verificationSuccess=2, verificationFailure=2
[ERROR] UrlUpdaterReportTest.testReportWithExistVersionsAndFailedDownloads:75
expected: mocked/mocked:addVersionSuccess=0, addVersionFailure=0, verificationSuccess=6, verificationFailure=6
but was: mocked/mocked:addVersionSuccess=0, addVersionFailure=0, verificationSuccess=0, verificationFailure=0
[INFO]
[ERROR] Tests run: 355, Failures: 3, Errors: 0, Skipped: 0

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your bugfixes. We've added some change requests and questions.
Co-Reviewed by: @alfeilex, @fahamzaoui

@hohwille
Copy link
Member Author

hohwille commented Oct 8, 2024

Thank you for your bugfixes. We've added some change requests and questions.

I reworked that already and IMHO all review feedback is addressed.
Did you test this already?
Do you have any hint how to proceed with the failing test? Is there a bug or is the test incorrect?

I would like to see what happens after we merged this and the UrlUpdater action ran again... Will this fix our problems or not.

Copy link

@fahamzaoui fahamzaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found an issue with npe please fix.

@hohwille hohwille merged commit a70b82c into devonfw:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eclipse related to Eclipse IDE urls ide-urls repo and related processes and features
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Eclipse download mirror does not have the requested file
4 participants