-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devonfw/ide-urls#17: fix UrlUpdater to auto-remove broken URLs and allow self-repair #681
devonfw/ide-urls#17: fix UrlUpdater to auto-remove broken URLs and allow self-repair #681
Conversation
cli/src/main/java/com/devonfw/tools/ide/url/model/file/UrlStatusFile.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/StatusJson.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/UrlStatus.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
Tests still failing:
|
cli/src/main/java/com/devonfw/tools/ide/url/model/file/json/UrlStatus.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/folder/AbstractUrlFolder.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/folder/AbstractUrlFolder.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/model/folder/AbstractUrlFolder.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your bugfixes. We've added some change requests and questions.
Co-Reviewed by: @alfeilex, @fahamzaoui
I reworked that already and IMHO all review feedback is addressed. I would like to see what happens after we merged this and the UrlUpdater action ran again... Will this fix our problems or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found an issue with npe please fix.
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
Show resolved
Hide resolved
…e is a solution for changing time in test
…port devonfw#618: Improvements for UrlUpdaterReportTest
fixes devonfw/ide-urls#17
or at least tries to fix the problem. Releases that are gone cannot come back but they will now be deleted if 404 have been detected for 14+ days.
If no valid URL remains for a version the entire version will be gone.
Therefore it will be recreated if it still exists (e.g. on different mirror).
I found and fixed many evil bugs and spent a long time debugging this mess...