Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements (git, processContext, step success) #645

Merged

Conversation

hohwille
Copy link
Member

  • fixed NPE I got when offline because ProcessResult.out was null
  • improved GitContext - instead of retrieving all branches and remotes and looking for * we can simply get current branch and default remote to simplify.
  • instead of checking online status 5 or more times via expensive remote operation, simply store the result
  • improve step success logging that was slightly confusing

@hohwille hohwille added enhancement New feature or request git process executing external programs (ProcessContext) step Logging and monitoring of process steps labels Sep 22, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 22, 2024
@hohwille hohwille self-assigned this Sep 22, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11016007304

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 126 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 65.927%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/context/GitContextImpl.java 45 50.99%
com/devonfw/tools/ide/context/AbstractIdeContext.java 81 60.25%
Totals Coverage Status
Change from base Build 10990744555: 0.2%
Covered Lines: 6045
Relevant Lines: 8827

💛 - Coveralls

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fixes, looks good to me. I've added some very small questions.

@jan-vcapgemini
Copy link
Contributor

Please add bugfix to changelog.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this to our changelog too. Ready to merge though.

@hohwille hohwille linked an issue Sep 24, 2024 that may be closed by this pull request
@hohwille
Copy link
Member Author

I think we should add this to our changelog too.

Done for #650
Other changes are all internal.

@hohwille hohwille merged commit 3ddcdd7 into devonfw:main Sep 24, 2024
3 checks passed
@hohwille hohwille linked an issue Sep 26, 2024 that may be closed by this pull request
hohwille pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request git process executing external programs (ProcessContext) step Logging and monitoring of process steps
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Improve default success message of step NullPointerException on GitContextImpl.retrieveRemoteAndBranchName
3 participants