Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#574: fixed getParentPath method #606

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

ndemirca
Copy link
Contributor

Closes #574

@ndemirca ndemirca marked this pull request as draft September 10, 2024 14:49
@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2024

Pull Request Test Coverage Report for Build 10846754171

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 94 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 65.822%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/context/AbstractIdeContext.java 94 60.42%
Totals Coverage Status
Change from base Build 10845846905: 0.03%
Covered Lines: 5971
Relevant Lines: 8743

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndemirca thanks for your PR and fix. Looks good to me 👍

IMHO this can be moved out of draft.

For the record: in devonfw-ide we resolved the link for the following use-case:
Assuming the end-user creates a symbolic link as a shortcut (e.g. of a repo inside a workspace into his home directory) then setting the environment via devon/ide would not work. However, if we resolve the link, it is still working. Now since we are using junctions and symbolic links in IDEasy, it caused bug #574. If later somebody complaints about this and wants to have this support back, we can still do the following: If IDE_HOME was not found this way, we do toRealPath() on the initial Path and rerun the code again that tries to find IDE_HOME from there. Not needed in this PR/Story but just wanted to explain this somewhere for general understanding.

@ndemirca ndemirca marked this pull request as ready for review September 13, 2024 07:53
@hohwille hohwille merged commit d3d3550 into devonfw:main Sep 13, 2024
4 checks passed
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 13, 2024
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

mismatch of working directory
4 participants