-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#574: fixed getParentPath method #606
#574: fixed getParentPath method #606
Conversation
Pull Request Test Coverage Report for Build 10846754171Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndemirca thanks for your PR and fix. Looks good to me 👍
IMHO this can be moved out of draft.
For the record: in devonfw-ide we resolved the link for the following use-case:
Assuming the end-user creates a symbolic link as a shortcut (e.g. of a repo inside a workspace into his home directory) then setting the environment via devon
/ide
would not work. However, if we resolve the link, it is still working. Now since we are using junctions and symbolic links in IDEasy, it caused bug #574. If later somebody complaints about this and wants to have this support back, we can still do the following: If IDE_HOME was not found this way, we do toRealPath()
on the initial Path and rerun the code again that tries to find IDE_HOME from there. Not needed in this PR/Story but just wanted to explain this somewhere for general understanding.
Closes #574