Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require user to agree to license #919

Closed
hohwille opened this issue Jan 13, 2025 · 0 comments · Fixed by #948
Closed

Require user to agree to license #919

hohwille opened this issue Jan 13, 2025 · 0 comments · Fixed by #948
Assignees
Labels
CLI IDEasy command-line-interface (parsing args, etc.) core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request

Comments

@hohwille
Copy link
Member

Before we go out of beta we need to implement a feature that the user has to agree to our license.
The idea is as following:

While this is planned for the installers (see #420 or #423) this should also be added to our CLI as a legal requirement before we go out of beta.
So the installer will create the same .license.agreement but if I installed IDEasy not via installer (e.g. because it does not yet exist or because I bypassed it by downloading the portal package) the CLI should do the same.
Unlike IDEasy we should not open browser windows automagically what caused a lot of confusion but just print the URL to the license, ask the user to read and confirm it. If he does not confirm the CLI will exit and not perform anything else.

Old implementation in devonfw-ide:
https://github.com/devonfw/ide/blob/8698d2ba7468d34aec82c86fabdb09b5ee84d9c8/scripts/src/main/resources/scripts/functions#L354-L385

New implementation should go somewhere around here:

Challenge is that the license agreement is a question (e.g. via askToContinue) that will use logging on level INTERACTION but that is invisible for Commandlets with processable output. Maybe we have to temporary enable such log-levels if the license is not yet agreed and then restore the previous logger state after that.

@hohwille hohwille added the enhancement New feature or request label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jan 13, 2025
@hohwille hohwille added CLI IDEasy command-line-interface (parsing args, etc.) core FileAccess, ProcessUtil, IdeContext, etc. labels Jan 13, 2025
@hohwille hohwille added this to the release:2025.01.002 milestone Jan 13, 2025
@hohwille hohwille self-assigned this Jan 16, 2025
@hohwille hohwille moved this from 🆕 New to 🏗 In progress in IDEasy board Jan 17, 2025
hohwille added a commit to hohwille/IDEasy that referenced this issue Jan 17, 2025
hohwille added a commit to hohwille/IDEasy that referenced this issue Jan 17, 2025
hohwille added a commit to hohwille/IDEasy that referenced this issue Jan 20, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Jan 20, 2025
hohwille added a commit that referenced this issue Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI IDEasy command-line-interface (parsing args, etc.) core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant