Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of plugins for IDEs fails when the plugin-id contains a space character #550

Closed
slskiba opened this issue Aug 22, 2024 · 0 comments · Fixed by #615
Closed
Assignees
Labels
bug Something isn't working plugins related to plugins (for Eclipse, Intellij, VSCode, etc.)

Comments

@slskiba
Copy link
Contributor

slskiba commented Aug 22, 2024

As an IDEasy user, I want to install plugins for my IDEs as defined by the plugins properties files in the provided settings.
In a plugin.properties file, the plugin_id may contain a space character (e.g. "PlantUML integration"), causing the download, and subsequently the installation of the plugin, to fail.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

Requirement: the PlantUMLIntegration.properties file needs to be present in settings/intellij/plugins, with the following content:

plugin_id=PlantUML integration
plugin_active=false

Then:

  1. Set plugin_active in PlantUMLIntegration.properties to true
  2. install intellij

Or alternatively:

  1. install-plugin intellij PlantUMLIntegration

Comments/Hints:

Replacing the space character of the plugin_id with "%20" makes the download succeed - however then the plugin installation fails at the extraction of the downloaded zip file. The field plugin_id in the properties file should keep the space character, to match the plugin_id provided from jetbrains.

@slskiba slskiba added bug Something isn't working plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) labels Aug 22, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Aug 22, 2024
@slskiba slskiba self-assigned this Aug 26, 2024
@slskiba slskiba moved this from 🆕 New to 🏗 In progress in IDEasy board Aug 26, 2024
@hohwille hohwille added this to the release:2024.09.002 milestone Sep 3, 2024
slskiba added a commit to slskiba/IDEasy that referenced this issue Sep 12, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugins related to plugins (for Eclipse, Intellij, VSCode, etc.)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants