fix problem with karma tests by updating to karma-webpack v4

from codymikol/karma-webpack#394
devlinjunker · May 3, 2020 · 2d91e99 · 2d91e99
1 parent 97567e5
commit 2d91e99
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 158 deletions.
diff --git a/karma.conf.js b/karma.conf.js
@@ -9,8 +9,6 @@ const env = {
 const webpack = buildWebpack(env);
 webpack.watch = true;
 
-console.log('TEST');
-
 const karmaConfig = function(config) {
   config.set({
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -76,7 +76,7 @@
     "karma-firefox-launcher": "^1.3.0",
     "karma-mocha": "^1.3.0",
     "karma-sourcemap-loader": "^0.3.7",
-    "karma-webpack": "^3.0.5",
+    "karma-webpack": "^4.0.2",
     "list-selectors": "^2.0.0",
     "madge": "^3.8.0",
     "mini-css-extract-plugin": "^0.9.0",

diff --git a/test/test.bootstrap.js b/test/test.bootstrap.js
@@ -7,15 +7,9 @@ chai.use(sinonChai);
 global.expect = chai.expect;
 global.sandbox = sinon.createSandbox();
 
-console.log('TEST');
-
 // $FlowFixMe
 const testsContext = require.context('../src', true, /.spec$/);
 
-console.log('TEST');
-console.log(testsContext);
-console.log('\n\n\n TESTING');
-
 testsContext.keys().forEach(testsContext);
 
 /* eslint-disable mocha/no-top-level-hooks,mocha/no-hooks-for-single-case */

diff --git a/webpack.config.js b/webpack.config.js
@@ -118,6 +118,8 @@ module.exports = (env) => {
         {
           test: /\.css$/,
           use: [
+            // Q: Should we do this during development and then use mini-css-extract-plugin
+            // during production?
             // {
             //   loader: 'style-loader',
             // },
@@ -176,7 +178,5 @@ module.exports = (env) => {
     });
   }
 
-  console.log('TEST1');
-
   return config;
 };