Merge pull request #10 from devlead/feature/improve/exceptionlogging

Improve exception logging & path escaping
devlead · Mar 25, 2024 · d9a74f2 · d9a74f2
2 parents a4b4e56 + 033d63b
commit d9a74f2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/ARI/Commands/InventoryCommand.cs b/src/ARI/Commands/InventoryCommand.cs
@@ -1,4 +1,5 @@
 using Cake.Common.IO;
+using Microsoft.Identity.Client;
 using System.Collections.Concurrent;
 
 namespace ARI.Commands;
@@ -27,7 +28,11 @@ public override async Task<int> ExecuteAsync(CommandContext context, InventorySe
         var modified = DateTimeOffset.UtcNow;
         var markDownFileName = settings.MarkdownName + ".md";
         var resourcesBag = new ConcurrentBag<(IResource Resource, DirectoryPath? Path)>();
-        settings.OutputPath = settings.OutputPath.MakeAbsolute(CakeContext.Environment);
+        if (settings.OutputPath.IsRelative)
+        {
+            Logger.LogInformation("Relative outputpath {outputpath} making absolute...", settings.OutputPath);
+            settings.OutputPath = settings.OutputPath.MakeAbsolute(CakeContext.Environment);
+        }
         Logger.LogInformation("TenantId: {TenantId}", settings.TenantId);
         Logger.LogInformation("OutputPath: {OutputPath}", settings.OutputPath);
         Logger.LogInformation("Generate report in parallel: {GenerateInParallel}", settings.SkipTenantOverview);

diff --git a/src/ARI/Extensions/StringMarkdownExtensions.cs b/src/ARI/Extensions/StringMarkdownExtensions.cs
@@ -30,7 +30,9 @@ public static string Link(this string description, string? href = default)
             : $"[{description}]({PathEscapeUriString(href ?? description)})";
 
     public static string PathEscapeUriString(this string path)
-        => path.Aggregate(
+        => path
+        .TrimStart('/', '\\')
+        .Aggregate(
                 new StringBuilder(),
                 (sb, c) => 
                             !char.IsAsciiLetterOrDigit(c)

diff --git a/src/ARI/Program.cs b/src/ARI/Program.cs
@@ -64,6 +64,10 @@
         config.AddCommand<InventoryCommand>("inventory")
                 .WithDescription("Example inventory command.")
                 .WithExample(new[] { "inventory", "00000000-0000-0000-0000-000000000000", "outputpath" });
+
+        config.SetExceptionHandler(
+            ex => AnsiConsole.WriteException(ex, ExceptionFormats.ShowLinks)
+            );
     });
 
 return await app.RunAsync(args);