Texture coordinate geenration for sphere map #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some conflicts after merging #82 sorry. Did I mess something up? |
This implementation comes with a big simplification: while the OpenGL specifications say that the texture coordinates should be computed as a reflection from the point of view of the camera, we do it as if the camera rays were all parallel to each other (that is, as if the camera was located infinitely far away). This approximation is acceptable for objects like spheres or with other curved surfaces, it works pretty badly with flat surfaces where all the normals have the same value, because in that case the same texel from the reflection texture gets applied over to the whole object. Also, GL_SPHERE_MAP should not be the same as GL_REFLECTION_MAP, because the resulting reflection vector should also be scaled down according to the distance from the viewer.
This implementation complies with the OpenGL specification. In a follow-up commit we will give the client the possibility to choose between this software implementation and the faster (but wrong) GPU implementation.
We might have more cases in the future, where we can choose between an accurate software implemenation and a faster but non-standard GPU implementation. Let's create a mechanism through which the client can select the features which can be sped up at the cost of correct rendering. This is currently exposed as an environment variable, and not as an API, because if it turns out to be a bad idea we can remove it without breaking the public API.
Implement the read_{pos,norm}() functions for the DirectVboReader class
too, because they are needed when generating texture coordinates.
No, you didn't. It's weird, because now that I rebased the branch locally, I had no conflicts at all. Anyway, I pushed the rebased branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed/merged after #82, since it's based on top of it.