Implement VBOs #78
Merged
Implement VBOs #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the vertex format setup to the array reader classes, as well as writing into the GX pipe. This not only buys us a little of performance, but having the array reading code next to the pipe writing allows us to implement improvements and new functionality more easily: for example, the SameTypeVertexReader classes store the vertex data as bytes of shorts into the GX pipe, if this is the data format specified by the client. This is also a step in the direction of implementing vertex buffers, since we should now be able to add a VertexReader subclass that handles indexed arrays (using GX_SetArray()).
The buffers are still disconnected from the drawing functions, this will come in a later commit.
Update the vertex data pointer in the VertexReader classes to point to the VBO data.
This is officially part of OpenGL 1.5, but it can be used in older versions too, as an extension.
If the GL format is natively supported by the GX API, we can use the GX_SetArray() function on the VBO data and then specify the elements as indices.
Add also all the other OpenGL 1.5 functions, though leave them commented out until we implement them.
Instead of adding duplicate entries for functions that were originally added as ARB extensions, just try to remove the ARB suffix, if we find it (e.g., when asked to lookup "glGenBuffersARB" we will look for "glGenBuffers").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertex buffers is a feature from OpenGL 1.5, but also present in older GL versions as an extension.