-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dell removed the ordernumbers, Moved over to DOQL for purchases #24
Open
blafkachel
wants to merge
42
commits into
device42:master
Choose a base branch
from
blafkachel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges due to life_cycle event
…alizing the array every loop
…hanged due to a life_cycle event
…in Device42 13.1.0)
…e option to be passed on to processing
…update on line items
…t if serial does not have proper warranty data
… Added error check to the API call
…esn't show it in API output anymore)
…dernumber. Prevents 1 purchase with 1000s of lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
primarely focussed on Dell.
I've added the shipdate as option for purchase registration. For Dell one used to be able to use the order number, but it is not part of the API anymore.
For gathering the. purchases the switch was made to use doql, way faster.
Increased api timeout. Sometimes dell seems to respond slower then expected.
Moved over to use Dells production API url, instead of sandbox.
When not enough rights in Device42 the DOQL output could produce only ordernumbers without purchaselines. Made sure the script stops there, as it would produce double registrations then.