Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image url for IOS success callback #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicolasgrolleau
Copy link

Replaced the use of UIImageWriteToSavedPhotosAlbum with the function
writeImageToSavedPhotosAlbum from the library ALAssetsLibrary
The aim of this change is to be able to return the image URL to the
success callback

writeImageToSavedPhotosAlbum from the library ALAssetsLibrary
The aim of this change is to be able to return the image URL to the
success callback
@jdivis
Copy link

jdivis commented Nov 18, 2015

@devgeeks Can we get this pulled into the master, so it's available @ https://www.npmjs.com/package/cordova-plugin-canvas2image (congrats on the semi-recent announcement, BTW).

.:Edit:.

Perhaps this is no longer required based on:

http://phonegap.com/blog/2015/11/19/config_xml_changes_part_two/

"instead of a version attribute the Cordova cli uses spec. spec is used both as a way to specify version (for npm) and also to specify the source repository of the plugin (eg. github:mygithubuser/myproject). Basically it allows anything that npm allows as part of it’s install command."

No examples of how to specify the source repository was given at the above link though. Will try something like:

<plugin name="com.phonegap.plugin.statusbar" source="npm" spec="github:mygithubuser/myproject" />

@jdivis
Copy link

jdivis commented Nov 24, 2015

I've been rebutted. Via BrettRudd the author of the phonegap blog, linked to above:

"@jasoncdivis pulling plugins from GitHub is not supported. it's on our roadmap. but would be public repos only."

I would still really like to see this enhancement available on npm.

@jdivis
Copy link

jdivis commented Nov 28, 2015

Rudd says this functionality is dropping in the first week of December: http://community.phonegap.com/nitobi/topics/correct-syntax-for-pulling-plugin-from-github-via-npm#reply_16367049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants