Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java liberty stack update feb2022 #95

Closed
wants to merge 1 commit into from

Conversation

ajm01
Copy link
Collaborator

@ajm01 ajm01 commented Feb 16, 2022

What does this PR do?:

added outer loop deploy commands and contexts to devfiles for demonstrating deploy thoughts for the liberty stacks

Which issue(s) this PR fixes:

n/a

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    the javaliberty and websphere-liberty tests all pass
  • Documentation
    Does any documentation need to be updated with your changes? - no

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ajm01

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2022

Hi @ajm01. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ajm01 ajm01 force-pushed the javaLiberty-stack-update-Feb2022 branch from 092f82b to 44d567b Compare February 16, 2022 21:58
@johnmcollier
Copy link
Member

/ok-to-test

@elsony
Copy link
Contributor

elsony commented Feb 23, 2022

Looks like the following issues are blocking this PR from running:
redhat-developer/odo#5451
redhat-developer/odo#5450
redhat-developer/odo#5452
We'll wait for those issues to be resolved before merging to avoid failing on the odo deploy command

@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2022

@ajm01: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnmcollier
Copy link
Member

@ajm01 can you rebase?

@johnmcollier
Copy link
Member

/retest

Copy link

openshift-ci bot commented Mar 14, 2024

@ajm01: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.7-registry-test 44d567b link true /test v4.7-registry-test
ci/prow/v4.11-registry-test 44d567b link true /test v4.11-registry-test
ci/prow/v4.11-images 44d567b link true /test v4.11-images
ci/prow/v4.12-images 44d567b link true /test v4.12-images
ci/prow/v4.12-registry-test 44d567b link true /test v4.12-registry-test
ci/prow/v4.13-registry-test 44d567b link true /test v4.13-registry-test
ci/prow/v4.13-images 44d567b link true /test v4.13-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thepetk
Copy link
Contributor

thepetk commented Apr 18, 2024

closing this PR as it's fairly old. If is a requirement feel free to re-open :)

@thepetk thepetk closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants