Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jhipster-online description #528

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Dec 16, 2024

Description of Changes

Summarize the changes you made as part of this pull request.
Updates the description of the JHipster devfile

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.
N/A

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@dkwon17 dkwon17 requested review from a team as code owners December 16, 2024 15:21
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick December 16, 2024 15:21
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 16, 2024
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jdubrick
Copy link
Contributor

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, Jdubrick, RomanNikitenko, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor

/retest

1 similar comment
@Jdubrick
Copy link
Contributor

/retest

@thepetk thepetk merged commit 477b9be into devfile:main Dec 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants