Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up e2e-tests to latest #297

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Feb 14, 2024

What does this PR do?:

This PR bumps up the redhat-appstudio/e2e-tests dependency to the v0.0.0-20240216111832-81d6508c8820 in order to address the CVE mentioned in the related issue.

Which issue(s) this PR fixes:

fixes devfile/api#1427

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge konflux-ci/e2e-tests#1043 first? Since it is the direct dependency tied to runc?

@thepetk
Copy link
Contributor Author

thepetk commented Feb 14, 2024

Should we merge redhat-appstudio/e2e-tests#1043 first? Since it is the direct dependency tied to runc?

Tried to trace where the opencontainers/runc is used as direct dependency. What I found is that is being used inside github.com/docker/docker, which is a direct dependency of github.com/openshift/oc (which is a direct dependency of e2e-tests).

As the redhat-appstudio/e2e-tests#1043 is pretty much the same PR like here I've closed it, because the rest of the dependencies related to the runc one haven't been updated yet. The PR pretty much tries to update the runc dependency to latest by:

go get -u github.com/opencontainers/runc

@thepetk thepetk force-pushed the fix/update_runc_to_latest branch from 7d7fbac to 2488a5c Compare February 19, 2024 12:43
@thepetk thepetk changed the title bump up runc to latest bump up e2e-tests to latest Feb 19, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Feb 19, 2024

Should we merge redhat-appstudio/e2e-tests#1043 first? Since it is the direct dependency tied to runc?

UPDATE: @michael-valdron after the update of the runc dependency in the e2e-tests repo (commit here) I think is better if we follow your suggestion and just update the e2e-tests dependency.

I've updated the PR and its description :)

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 463cdc1 into devfile:main Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address CVE-2024-21626
2 participants